iterate over fstab entries instead of relation data #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucabello
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
mmkay,
PietroPasotti,
sed-i and
simskij
as code owners
IbraAoad
reviewed
Mar 5, 2024
dstathis
previously requested changes
Mar 6, 2024
IbraAoad
reviewed
Mar 7, 2024
IbraAoad
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #56.
Solution
Instead of iterating over log slots in relation data, we iterate over fstab entries; this way, the behavior for 1. multiple logs slots being defined and 2. multiple paths in the same log slot, should be correct.
Testing Instructions
Deploy grafana-agent and relate it to the PostgreSQL charm or a charm with multiple slots.
This has been manually tested with the PostgreSQL charm and it produces all the scrape jobs correctly.