-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics and rules labeled from originating charm. #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to change charm-relation-interfaces correspondingly :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some reservations about the implementation, mostly ergonomic and opinionated.
But overall it looks good, so I'm not blocking.
Fixes #17
Issue
Previously we had all metrics and alert rules labeled with the topology of the principal charm. This caused issues as it was difficult, from charm code, to figure out which charm was principal. This also would have posed problems for multi-principal machines.
Solution
All alert rules and metrics now get topology labels from the charm from which they originated.
Testing Instructions
Release Notes
Simplified the labeling model of metrics and alert rules