Update docs and links #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These mainly fix things that seem to be leftovers from porting from the grafana-agent-k8s-operator codebase.
samuelallan72
requested review from
sed-i,
Abuelodelanada,
lucabello,
PietroPasotti,
dstathis and
simskij
as code owners
sed-i
reviewed
Nov 28, 2023
| @@ -17,10 +17,10 @@ maintainers: | |||
| - Luca Bello <[email protected]> | |||
| - Simon Aronsson <[email protected]> | |||
|
|
|||
| #docs: https://discourse.charmhub.io/t/grafana-agent-k8s-docs-index/5605 | |||
| docs: https://github.com/canonical/grafana-agent-operator/blob/main/README.md | |||
There was a problem hiding this comment.
- When there is no
docskey, charmhub automatically renderes the readme. - Currently there are no discourse docs so the
docskey should be omitted.
There was a problem hiding this comment.
@sed-i I'm not sure that's the case any more? Currently the readme is not rendered on charmhub for grafana-agent: https://charmhub.io/grafana-agent
There was a problem hiding this comment.
Ha, you're right. Alrighty, let's give this a try.
There was a problem hiding this comment.
Thanks, and thanks for reviewing and merging! :)
sed-i
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These mainly fix things that seem to be leftovers from porting
from the grafana-agent-k8s-operator codebase.
Fixes: #16
Fixes: #21