Add probes (WIP) #213
Draft
Add probes (WIP) #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| print( | ||
| f"{name} is related to more than one grafana-agent subordinate: {subord_agents}" | ||
| ) | ||
|
|
There was a problem hiding this comment.
We should add this probe
def one_cos_proxy_to_nrpe_monitors(status: dict):
"""Can have only one cos-proxy related to nrpe:monitors."""
...| for k, v in counter.items(): | ||
| if len(v) > 1: | ||
| print(f"App '{k}' related to multiple grafana-agent apps '{v}'") | ||
|
|
There was a problem hiding this comment.
We should add this probe
def one_cos_proxy_to_nrpe_monitors(bundle: dict):
"""Can have only one cos-proxy related to nrpe:monitors."""
...
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Need a quick way to determine if grafana-agent deployment is correct.
Solution
Add a few external probes, runnable against a bundle or a status.
Context
https://discourse.charmhub.io/t/how-to-testing-cos-integrations/14532
Testing Instructions
Per committed README.