Make cos_agent charm library compatible with Pydantic v1/v2
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiiwang01
force-pushed
the
cos-agent-pydantic
branch
from
75ad957 to
1e28967
Compare
weiiwang01
force-pushed
the
cos-agent-pydantic
branch
from
1e28967 to
e6816a1
Compare
Abuelodelanada
approved these changes
Aug 8, 2024
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Partially fixes #114, where the
cos_agentcharm library is not compatible with charms or other charm libraries that use Pydantic v2.Solution
Pydantic v2 provides full v1 compatibility via the
pydantic.v1namespace. When it is detected that the environment is using Pydantic v2, switch to using that instead of importing Pydantic v2.Upgrade Notes
This should have no impact on any existing charms.