Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the title of the node-exporter dashboard #333

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

cbartz
Copy link
Contributor

@cbartz cbartz commented Dec 2, 2024

Issue

There is a dashboard title collision with the one in the grafana-agent machine charm.

Solution

Rename the title as suggested in https://github.com/canonical/observability/pull/206/files#r1863947198
uid collision will be addressed later as indicated in canonical/observability#206.

Rename the title of the dashboard to avoid collision with the dashboard in the grafana-agent machine charm.

Signed-off-by: Christopher Bartz <[email protected]>
@cbartz cbartz requested a review from a team as a code owner December 2, 2024 14:19
Copy link
Contributor

@sed-i sed-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually, works:

curl http://admin:[email protected]:3000/api/search   
[
  {
    "id": 1,
    "uid": "rYdddlPWk-1",
    "title": "System Resources (container)",
    "uri": "db/system-resources-container",
    "url": "/d/rYdddlPWk-1/system-resources-container",
    "slug": "",
    "type": "dash-db",
    "tags": [
      "linux"
    ],
    "isStarred": false,
    "sortMeta": 0
  }
]

@sed-i sed-i merged commit 4dc97f6 into canonical:main Dec 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants