Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add open port support #287

Merged
merged 3 commits into from
Apr 16, 2024
Merged

add open port support #287

merged 3 commits into from
Apr 16, 2024

Conversation

lucabello
Copy link
Contributor

Issue

Use ops.Unit.open_port for the port to show up in Juju status.

Due to a Juju bug, it might not show up there yet; use juju exec <unit> -- opened-ports to verify.

Testing Instructions

charmcraft pack
juju deploy ./grafana-agent-k8s_ubuntu-22.04-amd64.charm agent
# Wait for the charm
juju exec --unit agent/0 -- opened-ports

@lucabello lucabello merged commit 1adee25 into main Apr 16, 2024
13 checks passed
@lucabello lucabello deleted the feature/open-port branch April 16, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IbraAoad IbraAoad IbraAoad approved these changes

@Abuelodelanada Abuelodelanada Awaiting requested review from Abuelodelanada

@dstathis dstathis Awaiting requested review from dstathis

@mmkay mmkay Awaiting requested review from mmkay

@PietroPasotti PietroPasotti Awaiting requested review from PietroPasotti

@sed-i sed-i Awaiting requested review from sed-i

@simskij simskij Awaiting requested review from simskij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucabello @IbraAoad