Update dashboards when relation broken #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the relation between grafana-agent and a charm providing a dashboard (over the grafana-dashboards-consumer relation) was broken, the dashboards would not be removed. This fixes that issue, by also running the dashboards changed method when the relation is broken.
samuelallan72
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
lucabello,
mmkay,
PietroPasotti,
sed-i and
simskij
as code owners
sed-i
approved these changes
Apr 10, 2024
|
Thanks @samuelallan72! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the relation between grafana-agent and a charm providing a dashboard
(over the grafana-dashboards-consumer relation)
was broken, the dashboards would not be removed.
This fixes that issue, by also running the dashboards changed method when the relation is broken.
Testing Instructions
/var/lib/juju/agents/unit-grafana-agent-0/charm/grafana_dashboards/in grafana-agent-k8s.