feat: Add arm64 support #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghislainbourgeois
requested review from
sed-i,
Abuelodelanada,
lucabello,
PietroPasotti,
dstathis and
simskij
as code owners
simskij
approved these changes
Jan 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Makes the charm useable on arm64.
Solution
Enables packing the charm on arm64.
Context
I am testing Charmed 5G's Control Plane bundle on arm64, requiring the grafana-agent for observability.
Testing Instructions
Can be tested by packing the charm on an arm64 machine (Raspberry Pi 4/5, Apple M1, etc.). It will require the OCI image to also be built for arm64: canonical/grafana-agent-rock#29
Release Notes
Added arm64 support