Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the utility charm #5

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Improvements to the utility charm #5

merged 7 commits into from
Jan 12, 2024

Conversation

wood-push-melon
Copy link
Contributor

@wood-push-melon wood-push-melon commented Jan 8, 2024 •
edited
Loading

This pull request includes the following:

  • Handle group association when creating a group
  • Use Pydantic in the auxiliary interface library
  • Some refactors
  • Improvements in the documentation

This pull request should be shipped out first before the glauth-k8s's PR since it needs the utility interface library published.

@wood-push-melon wood-push-melon marked this pull request as ready for review January 9, 2024 03:47
@wood-push-melon wood-push-melon requested a review from a team as a code owner January 9, 2024 03:47
@wood-push-melon wood-push-melon mentioned this pull request Jan 9, 2024
Merged
5 tasks
@wood-push-melon wood-push-melon changed the title Some improvements to the utility charm Improvements to the utility charm Jan 9, 2024
natalian98
natalian98 reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@natalian98 natalian98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I have some minor comments.

lib/charms/glauth_utils/v0/glauth_auxiliary.py Show resolved Hide resolved
src/parser.py Outdated Show resolved Hide resolved
src/parser.py Show resolved Hide resolved
@wood-push-melon wood-push-melon merged commit 927ce47 into main Jan 12, 2024
4 checks passed
@wood-push-melon wood-push-melon deleted the IAM-630 branch January 12, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalian98 natalian98 natalian98 left review comments

@nsklikas nsklikas nsklikas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wood-push-melon @nsklikas @natalian98