feat!: add ingress_per_unit integration to glauth-k8s-operator #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ingress_per_unit integration to glauth-k8s so that the glauth TCP service can be addressable from machine charms outside of the Kubernetes cluster. Now, when a machine charm wants to connect to glauth for LDAP goodness, all you need to do is integrate glauth-k8s with traefik:
Breaking changes
One thing to note is that I updated the function signature of the
ldap_url
to returnList[str]
instead ofstr
. I don't think it's that much of an issue asldap_url
is only used two times within the operator, and its returned value was casted toList[str]
to satisfy the type requirements for the urls field in the ldap interface.Related issues