-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tls-certificates & certificate-transfer interface integrations #20
Conversation
2097e4b
to
af365cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- On
config_changed
you need to update theCertHandler
config with the new hostname - I have mixed feelings about the
integrations.py
file. It makes sense for removing some of the logic from thecharm.py
file, but at the same time it feels like it beats the purpose of having a lib. Libs should provide as much functionality as possible only through config. For example, ifCertificateTransferProvides
provided a function for updating all the relations with one call, you wouldn't need to wrap it. In addition, it makes each charm implement different patterns (especially across teams) and I think that we should strive for a uniform approach across charms. Having said that this is a nitpick and I have no problem with moving on with the current implementation, until we can better evaluate this approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another question:
Shouldn't the glauth config be updated to use the cert after it is recieved?
Shall we add this piece of config to the template? |
I am confused with the first one. The For the second, the |
This task is in the scope of https://warthogs.atlassian.net/browse/IAM-621. It needs us to decide if we want the StartTLS in mandatory. I will leave some comments on the ticket. |
af365cc
to
f4ab3d6
Compare
I think this is related to another ticket's task: https://warthogs.atlassian.net/browse/IAM-621. And it needs us to make some decisions. |
This pull request tries to implement the integration with
tls-certificates
interface andcertificate-transfer
interface.