Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert snap build to core22 #310

Merged
merged 1 commit into from
Oct 3, 2024
Merged

chore: revert snap build to core22 #310

merged 1 commit into from
Oct 3, 2024

Conversation

sminez
Copy link
Contributor

@sminez sminez commented Oct 3, 2024

No description provided.

@sminez sminez requested a review from seb128 October 3, 2024 12:42
seb128
seb128 requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but you also need to revert the use of the platform property since that is a core24 syntax, see b84d8bd41

(might be easier to do a 'git revert ' for those changes?

@sminez sminez requested a review from seb128 October 3, 2024 12:51
seb128
seb128 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sminez sminez requested a review from seb128 October 3, 2024 13:07
seb128
seb128 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sminez sminez requested a review from seb128 October 3, 2024 13:20
seb128
seb128 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if that's the one! :-)

@sminez sminez merged commit ce30083 into main Oct 3, 2024
9 checks passed
@sminez sminez deleted the revert-to-core22 branch October 3, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seb128 seb128 seb128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sminez @seb128