Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate an AlertDialog screen when A/C must be applied for some updates to proceed - this is issue #215. #256

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Glen-Campbell-Bose
Copy link

Add an alert dialog that looks like this:

image

Copy link

github-actions bot commented Jan 18, 2024

Everyone contributing to this PR have now signed the CLA. Thanks!

@Glen-Campbell-Bose
Copy link
Author

Pardon the newbie stuff here - trying to get my ducks in a row with regard to submissions ...

@d-loose
Copy link
Member

d-loose commented Feb 1, 2024

Thanks for your contribution!
Unfortunately the firmware updater doesn't get the attention it deserves at the moment, as our team is working on other projects with higher priority for 24.04, so respond times are likely to remain slow - my apologies!

I noticed that we still don't have a proper contribution guide for this repo - @BLKKKBVSIK could you create one similar to the one we have for app-center if you got some spare time in the next weeks?

Concerning your PR - thanks, I think this is an improvement over the subtle and confusing banner on the top of the window. I hope @anasereijo can give you some feedback on the UI at some point. Besides that, you'd need to take a look at the failing tests. With a UI change like this, some of them might need to be adjusted. Please let us know if you need any help, although we can't guarantee very quick replies at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants