Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve progress indicators #111

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

d-loose
Copy link
Member

@d-loose d-loose commented Oct 18, 2022

Minor UI updates:

  • reduce stroke width of YaruCircularProgressIndicator as suggested by @Feichtmeier
  • use YaruLinearProgressIndicator instead of LinearProgressIndicator
  • add padding
Dark Light
Before Screenshot from 2022-10-18 17-23-26 Screenshot from 2022-10-18 17-23-34
After Screenshot from 2022-10-18 17-17-08 Screenshot from 2022-10-18 17-17-19

@d-loose d-loose requested a review from jpnurmi October 20, 2022 09:33
@jpnurmi
Copy link
Contributor

jpnurmi commented Oct 20, 2022

@elioqoshi What do you think? I'm no designer but personally, I feel like the slim and rectangular progress bar fits this context better. :)

@d-loose
Copy link
Member Author

d-loose commented Oct 20, 2022

I have to admit I like it better too - just added it for consistency with the rest of the yaru widgets :D

@Feichtmeier
Copy link
Contributor

Maybe just add a percentage text left of the spinner?
I feel like two indicators are overkill

@jpnurmi
Copy link
Contributor

jpnurmi commented Oct 20, 2022

A thinner spinner alone would be an immediate approval though! 😉

@d-loose
Copy link
Member Author

d-loose commented Nov 15, 2022

I don't feel qualified to make any of these UX/UI decisions :D
@elioqoshi we know your time is precious and very limited, but I'd really appreciate some feedback on some of these questions (no need for any mockups):

  • I'd like to use the Yaru widgets wherever possible, so I'd prefer using Yaru's linear progress indicator. But I also agree with @jpnurmi - the rounded bar looks weird when it spans the entire width of the page. Maybe we could simply add some horizontal margin?
  • Are two indicators too many? I added the circular spinner to indicate that some work is still being done in the background, even if the linear progress indicator doesn't change for a couple of seconds. In general I prefer a visual indicator over a numerical percentage. What do you think?
    Something to keep in mind concerning the progress bars: the linear indicator displays the progress of the current step of the update (fwupd typically goes through multiple steps like downloading, verifying, reading, writing ... and reports a progress for each of those). There's no (easy) way to get the total progress (or does someone have a good idea?).

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants