Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow-specifying-base-image #127

Merged
merged 7 commits into from
Jul 18, 2024
Merged

allow-specifying-base-image #127

merged 7 commits into from
Jul 18, 2024

Conversation

samhotep
Copy link
Member

Allow dotrun users to specify an image or release for the dotrun docker container. The image supplied can also be a local image.

Done

  • Added --image flag
  • Added --release flag
  • Added refresh option to re-download the latest dotrun image

QA

  • Create a new virtualenv
  • Checkout this branch and install dotrun using
chmod +x build.sh
./build.sh
  • Download the latest dotrun image
dotrun refresh
  • Change directory to an existing website, such as ubuntu.com and run dotrun with the --release flag
dotrun clean
dotrun --release latest install
dotrun --release latest serve
  • Also run with the --image flag

You can create a new local dotrun image using the following

docker pull origin canonicalwebteam/dotrun-image:latest
docker tag canonicalwebteam/dotrun-image:latest canonicalwebteam/dotrun-image:testimage

And then specify the new local image

dotrun clean
dotrun --image canonicalwebteam/dotrun-image:testimage install
dotrun --image canonicalwebteam/dotrun-image:testimage serve

@samhotep samhotep force-pushed the allow-specifying-base-dotrun branch from 84856e1 to 6f443f3 Compare July 15, 2024 22:15
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General idea and implementation LGTM

Some comments and ideas to improve readability.

README.md Outdated Show resolved Hide resolved
dotrun.py Outdated Show resolved Hide resolved
dotrun.py Outdated Show resolved Hide resolved
dotrun.py Outdated Show resolved Hide resolved
dotrun.py Outdated Show resolved Hide resolved
@samhotep samhotep merged commit 8b458d6 into main Jul 18, 2024
3 checks passed
@samhotep samhotep deleted the allow-specifying-base-dotrun branch July 18, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants