Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove [INFO] prefix from stdout logs #169

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Remove [INFO] prefix from stdout logs #169

merged 5 commits into from
Aug 28, 2024

Conversation

misohu
Copy link
Member

@misohu misohu commented Aug 27, 2024 •
edited
Loading

Closes: #158

  • Removing [INFO] prefix from stdout logs. We want to keep it in the logs file.
  • Changing docs to reflwct the change
  • Adding unit tests for logger

How to test:

git clone <repo>
cd <repo>
pip install .
dss status

The logs in console should not have [INFO]

@misohu misohu requested a review from a team as a code owner August 27, 2024 12:53
mvlassis
mvlassis reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@mvlassis mvlassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Michal!

tests/unit/test_logger.py Outdated Show resolved Hide resolved
mvlassis
mvlassis approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@mvlassis mvlassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@misohu misohu merged commit b368068 into main Aug 28, 2024
9 checks passed
@misohu misohu deleted the KF-6098-remove-info-from-logs branch August 28, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvlassis mvlassis mvlassis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove [INFO] prefix for info logs
2 participants
@misohu @mvlassis