Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(integration_test_charm.yaml): Enable RBAC for microk8s tests #256

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Dec 18, 2024

Enable RBAC during microk8s setup in line with the default behaviour of charmed-kubernetes/actions-operator

@dragomirp
Copy link
Contributor Author

Set as breaking change as it may cause issues with test that don't set trust. Tested on https://github.com/canonical/pgbouncer-k8s-operator/actions/runs/12392459034/job/34593413343?pr=474

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I also increase the microk8s-setup's timeout?

@dragomirp dragomirp marked this pull request as ready for review December 18, 2024 12:43
Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the purpose of this change to test --trust?

rbac Enable Role Based Access Control for authorisation. Note that this is incompatible with some other add-ons.

from https://microk8s.io/docs/addons

will this cause incompatibilities with other addons that we use? e.g. metallb


I think we'll be refactoring how we work with microk8s addons during the move to charmcraft test/spread/concierge and would prefer to avoid changing defaults before then, unless there's a significant benefit

@dragomirp
Copy link
Contributor Author

is the purpose of this change to test --trust?

Kind of. There are already tests for it in PG/PGB (enabling RBAC during the Pytest run, tests get stuck during model cleanup), but they fail on libjuju 3.6.0.0. Beyond that, RBAC would be expected in production environments.

rbac Enable Role Based Access Control for authorisation. Note that this is incompatible with some other add-ons.

from https://microk8s.io/docs/addons

will this cause incompatibilities with other addons that we use? e.g. metallb

I don't think so, at least I had no issues locally with RBAC and metallb. RBAC is also enabled by default by the actions-operator we used before switching to DPW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants