Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use ops[testing] rather than ops-scenario<7 #97

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

tonyandrewmeyer
Copy link
Contributor

Issue

cos-lib currently pins ops-scenario to <7, which means that any charms that are using cos-lib are also stuck with that version of scenario.

Solution

Updates to the latest published version of ops-scenario, and also to installing with ops[testing] and using from the ops.testing namespace.

Context

Latest scenario/ops.

Testing Instructions

tox

Upgrade Notes

N/A, only tests are changed.

@tonyandrewmeyer tonyandrewmeyer requested a review from a team as a code owner November 11, 2024 03:47
Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this! LGTM. the integration test PRs fail because my actions aren't ready to do cross-repo checkouts

@PietroPasotti PietroPasotti merged commit 14c27b4 into canonical:main Nov 14, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants