Add guard against coordinator publishing worker config #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroPasotti
requested changes
Oct 11, 2024
PietroPasotti
approved these changes
Oct 14, 2024
michaeldmitry
force-pushed
the
publish-requirer-first
branch
from
4e5ddd1 to
33179f4
Compare
michaeldmitry
force-pushed
the
publish-requirer-first
branch
from
079fb61 to
155c90c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
A coordinator should not publish the config to a worker if a worker has not yet published its own data (like roles and addresses).
Solution
Add a guard to check if the worker has already published its data right before we try and send the config to that worker.