-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dashboard uid generation helper #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
Abuelodelanada
approved these changes
Dec 18, 2024
MichaelThamm
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Co-authored-by: Michael Thamm <[email protected]> Signed-off-by: Leon <[email protected]>
sed-i
force-pushed
the
feature/dashboard_module
branch
from
December 20, 2024 19:56
7066173
to
57ca8f9
Compare
This was referenced Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
New function for rendering dashboard uid
In tandem with:
Extract LZMA base64 logic from GrafanaDashboard class
Also, deprecate the GrafanaDashboard class.
The new LZMABase64 class is consistent with the following view:
Context
This change was prompted by an ADR for addressing dashboard UID collisions.
Testing Instructions
This is an ops-independent change. See unit tests.
Upgrade Notes
If dependent code is using
grafana_dashboard.GrafanaDashboard
, a deprecation warning will now be printed. Switch to usingLZMABase64
.