Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directly vendor schema files #110

Merged
merged 18 commits into from
Dec 10, 2024
Merged

directly vendor schema files #110

merged 18 commits into from
Dec 10, 2024

Conversation

PietroPasotti
Copy link
Contributor

@PietroPasotti PietroPasotti commented Dec 10, 2024

Issue

Pypi packages apparently cannot depend on git+ dependencies.
https://github.com/canonical/cos-lib/actions/runs/12252877996/job/34180522427

charm-relation-interfaces is not on pypi (yet)

Solution

Instead of installing 'interfaces' from git, download them in this repository tree for the time being.
This is a short term workaround, not a solution.
If charm-relation-interfaces is not to be on pypi, a better approach would be to pull the schemas automatically from CI every time there's a merge on CRI main.

@PietroPasotti PietroPasotti requested a review from a team as a code owner December 10, 2024 09:48
@PietroPasotti PietroPasotti merged commit 1b42954 into main Dec 10, 2024
6 of 7 checks passed
@PietroPasotti PietroPasotti deleted the datasource_exchange branch December 10, 2024 11:00
@NucciTheBoss
Copy link

@PietroPasotti what was the reason for adding cryptography as a dependency in pyproject.toml? As of the latest cosl release, every charm that pulls in cosl will need to include a Rust toolchain during the packing process to compile cryptography, or add an entry for cryptography in charm-binary-python-packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants