Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default k8s snap channel #85

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Fix default k8s snap channel #85

merged 2 commits into from
Dec 6, 2024

Conversation

petrutlucian94
Copy link
Contributor

@petrutlucian94 petrutlucian94 commented Dec 4, 2024 •
edited
Loading

This commit ensures that the "-classic/stable" channel is used if no snap channel, revision or path is provided.

@petrutlucian94 petrutlucian94 requested a review from a team as a code owner December 4, 2024 14:41
@petrutlucian94
Fix default k8s snap channel
c59f679 
This commit ensures that the "-classic/edge" channel is used if
no snap channel, revision or path is provided.

We cannot use "stable" since we don't have a stable channel yet.
berkayoz
berkayoz reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default should always be stable, even if we don't have the tracks yet. We can adjust to use the 1.32 stable track which should be released soon.

Thanks for fixing the if check for defaulting.

@petrutlucian94
Switch back to "stable" by default
a992450 
A stable release of k8s-snap is expected to come out soon, so we'll
stick to using "stable" by default instead of "edge".
@petrutlucian94
Copy link
Contributor Author

The default should always be stable, even if we don't have the tracks yet. We can adjust to use the 1.32 stable track which should be released soon.

I see, I've switched the default channel back to "stable".

bschimke95
bschimke95 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, I think that needs to be rebased on main to include the CI fixes.

pkg/cloudinit/common.go Show resolved Hide resolved
@bschimke95 bschimke95 merged commit 058e0d8 into canonical:main Dec 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkayoz berkayoz berkayoz left review comments

@bschimke95 bschimke95 bschimke95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petrutlucian94 @berkayoz @bschimke95