Support running e2e tests on AWS #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaudetcobello
changed the title
bschimke95
reviewed
Aug 20, 2024
There was a problem hiding this comment.
great work @eaudetcobello, added couple of comments
we should probably get #22 in before this.
neoaggelos
reviewed
Aug 20, 2024
eaudetcobello
force-pushed
the
KU-1266/e2e-test-aws
branch
4 times, most recently
from
4764011 to
923b3cf
Compare
eaudetcobello
force-pushed
the
KU-1266/e2e-test-aws
branch
21 times, most recently
from
a259d47 to
9b7796f
Compare
eaudetcobello
force-pushed
the
KU-1266/e2e-test-aws
branch
from
f9ec39a to
2f54e43
Compare
bschimke95
reviewed
Oct 23, 2024
bschimke95
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
LGTM, great stuff @eaudetcobello
Thanks for pushing through it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster_upgrade_test.go → Here we replace the hardcoded reference to docker infrastructure and instead tell the test suite to resolve `. This is then read from the config. file of the test (I think), which lives at test/config/ck8s-{docker,aws}.yaml
create_test.go → same as above.
test/e2e/data/infrastructure-aws folder → this folder contains the templates that will be applied to the cluster during the test.
test/e2e/shared/v1beta1 → this defines the major and minor contract version of the core cluster api components that we use for the tests. (See ck8s-aws.yaml line 25)
test/e2e/shared/v1beta1_aws → this defines the major and minor contract version of the CAPA resources we deploy. (See ck8s-aws.yaml Line 38)
kcp_remediation_test.go, md_remediation_test.go, node_scale_test.go → Changed the hardcoded docker provider to clusterctl.DefaultInfrastructureProvider. Also, skip remediation tests on cloud provider.
Makefile -> added E2E_INFRA variable that can be specified like
E2E_INFRA=aws make test-e2e