Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPI e2e tests #13

Merged
merged 68 commits into from
Jul 18, 2024
Merged

CAPI e2e tests #13

merged 68 commits into from
Jul 18, 2024

Conversation

bschimke95
Copy link
Contributor

@bschimke95 bschimke95 commented Jun 20, 2024

Summary

This PR enables and fixes the e2e tests for our CAPI providers. Specifically they test that:

  • Workload clusters can be created and correctly form a cluster.
  • Clusters can be scaled up and down
  • Machines are remediated if they are unhealthy

Right now, the machine upgrade test is disabled as it is more involved. This will be tackled as follow-up work.

Notable changes

  • Adds a Dockerfile to build the providers
  • Fix api versions for cluster templates
  • Move WaitForNodesReady from the CAPI test framework to the helpers as we only want to test for the minor Kubernetes version while framework.WaitForNodesReady does a full version check

@bschimke95 bschimke95 force-pushed the KU-968/capi-e2e branch 5 times, most recently from 2613e9e to d4ee7ed Compare June 27, 2024 17:39
@bschimke95 bschimke95 changed the base branch from main to KU-963/node-deletion June 27, 2024 17:41
@bschimke95 bschimke95 force-pushed the KU-968/capi-e2e branch 2 times, most recently from 3ec9163 to bb03d5b Compare June 28, 2024 12:26
@bschimke95 bschimke95 marked this pull request as ready for review June 28, 2024 12:27
@bschimke95 bschimke95 requested a review from neoaggelos as a code owner June 28, 2024 12:27
@@ -28,7 +28,7 @@ patchesStrategicMerge:
# Protect the /metrics endpoint by putting it behind auth.
# If you want your controller-manager to expose the /metrics
# endpoint w/o any authn/z, please comment the following line.
- manager_auth_proxy_patch.yaml
#- manager_auth_proxy_patch.yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling this caused the e2e tests to fail.

@bschimke95 bschimke95 changed the title [WIP] CAPI e2e tests CAPI e2e tests Jun 28, 2024
@bschimke95 bschimke95 changed the base branch from KU-963/node-deletion to main June 28, 2024 15:21
@bschimke95 bschimke95 force-pushed the KU-968/capi-e2e branch 3 times, most recently from 724f440 to 58c6141 Compare July 2, 2024 12:20
@bschimke95 bschimke95 changed the base branch from main to KU-875/provider-images July 2, 2024 12:21
@bschimke95 bschimke95 force-pushed the KU-875/provider-images branch 2 times, most recently from fa21655 to 5fc25dd Compare July 3, 2024 07:01
@bschimke95 bschimke95 force-pushed the KU-968/capi-e2e branch 2 times, most recently from d809aa7 to d044117 Compare July 3, 2024 08:42
@bschimke95 bschimke95 changed the base branch from KU-875/provider-images to main July 3, 2024 08:54
@bschimke95 bschimke95 force-pushed the KU-968/capi-e2e branch 2 times, most recently from e9e0670 to 4d592c8 Compare July 5, 2024 09:08
test/e2e/helpers.go Outdated Show resolved Hide resolved
eaudetcobello

This comment was marked as duplicate.

Copy link
Contributor

@eaudetcobello eaudetcobello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also update the README.md with instructions for running these locally

get-docker.sh Outdated Show resolved Hide resolved
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
test/e2e/helpers.go Outdated Show resolved Hide resolved
test/e2e/e2e_suite_test.go Outdated Show resolved Hide resolved
test/e2e/docker_logcollector.go Outdated Show resolved Hide resolved
@bschimke95 bschimke95 merged commit f74ddc3 into main Jul 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants