Skip to content

Commit

Permalink
cleanup temlate todos
Browse files Browse the repository at this point in the history
  • Loading branch information
bschimke95 committed Jun 28, 2024
1 parent 7c0bf43 commit 8f315f5
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 11 deletions.
3 changes: 1 addition & 2 deletions pkg/ck8s/manifests/k8sd-proxy-template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ spec:
effect: NoSchedule
containers:
- name: k8sd-proxy
# TODO: change back to ghcr image once this is public
image: alpine/socat:1.8.0.0
image: ghcr.io/canonical/cluster-api-k8s/socat:1.8.0.0
env:
# TODO: Make this more robust by possibly finding/parsing the right IP.
# This works as a start but might not be sufficient as the kubelet IP might not match microcluster IP.
Expand Down
8 changes: 0 additions & 8 deletions pkg/cloudinit/controlplane_init_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,20 +46,12 @@ func TestNewInitControlPlane(t *testing.T) {

// TODO: add tests for expected files and commands
g.Expect(err).To(BeNil())
g.Expect(config.WriteFiles).To(ContainElement(cloudinit.File{
Path: "/tmp/file",
Content: "test file",
Permissions: "0400",
Owner: "root:root",
}))
g.Expect(config.BootCommands).To(ContainElement("bootcmd"))
g.Expect(config.RunCommands).To(Equal([]string{
"set -x",
"prerun1",
"prerun2",
"/capi/scripts/install.sh",
"/capi/scripts/bootstrap.sh",
"/capi/scripts/load-images.sh",
"/capi/scripts/wait-apiserver-ready.sh",
"/capi/scripts/deploy-manifests.sh",
"/capi/scripts/configure-token.sh",
Expand Down
1 change: 0 additions & 1 deletion test/e2e/data/infrastructure-docker/cluster-template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ metadata:
spec:
template:
spec:
# TODO: make this customable
customImage: k8s-snap:dev
---
apiVersion: bootstrap.cluster.x-k8s.io/v1beta2
Expand Down

0 comments on commit 8f315f5

Please sign in to comment.