-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new disableDefaultCNI field #109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits... LGTM though
eaudetcobello
force-pushed
the
eaudetcobello/KU-1189
branch
from
July 26, 2024 18:17
d9278ba
to
30ba873
Compare
eaudetcobello
force-pushed
the
eaudetcobello/KU-1189
branch
from
July 26, 2024 19:07
1006bf7
to
a6aaa02
Compare
eaudetcobello
force-pushed
the
eaudetcobello/KU-1189
branch
from
July 29, 2024 18:55
836b9db
to
21373e2
Compare
eaudetcobello
added a commit
to canonical/cluster-api-control-plane-provider-microk8s
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new field to the MicroK8s bootstrap provider called
disableDefaultCNI
.When this field is set to true, Calico will be disabled by 1.
microk8s kubectl delete -f cni.yaml
and 2. renaming the CNI file fromcni.yaml
tocalico.yaml.old
The objective is to disable the default CNI on the control planes so that when workers join the default CNI is not deployed to them. The user is expected to provide a new CNI using postRunCommands.