Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create delete package endpoint #1684

Merged

Conversation

codeEmpress1
Copy link
Contributor

Done

  • add endpoint to unregister package name

How to QA

Issue / Card https://warthogs.atlassian.net/browse/WD-6599

Fixes #

Screenshots

@webteam-app
Copy link

Demo starting at https://charmhub-io-1684.demos.haus

Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #1684 (22082f4) into main (05c3c73) will decrease coverage by 0.01%.
The diff coverage is 42.85%.

❗ Current head 22082f4 differs from pull request most recent head 3c6ee14. Consider uploading reports for the commit 3c6ee14 to get more accurate results

@@            Coverage Diff             @@
##             main    #1684      +/-   ##
==========================================
- Coverage   42.89%   42.89%   -0.01%     
==========================================
  Files          20       20              
  Lines        1667     1674       +7     
==========================================
+ Hits          715      718       +3     
- Misses        952      956       +4     
Flag Coverage Δ
python 42.89% <42.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webapp/publisher/views.py 38.26% <42.85%> (+0.17%) ⬆️

@codeEmpress1 codeEmpress1 merged commit fd80caf into canonical:main Oct 11, 2023
8 checks passed
@codeEmpress1 codeEmpress1 deleted the create-delete-package-endpoint branch October 11, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants