Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update charmhub beta #1670

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Conversation

codeEmpress1
Copy link
Contributor

@codeEmpress1 codeEmpress1 commented Sep 26, 2023

Done

  • update beta app

How to QA

Issue / Card

Fixes #

Screenshots

@webteam-app
Copy link

Demo starting at https://charmhub-io-1670.demos.haus

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #1670 (0932883) into main (0b30aca) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

❗ Current head 0932883 differs from pull request most recent head 050a622. Consider uploading reports for the commit 050a622 to get more accurate results

@@            Coverage Diff             @@
##             main    #1670      +/-   ##
==========================================
- Coverage   43.17%   42.94%   -0.24%     
==========================================
  Files          20       20              
  Lines        1656     1658       +2     
==========================================
- Hits          715      712       -3     
- Misses        941      946       +5     
Flag Coverage Δ
python 42.94% <0.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webapp/decorators.py 65.51% <0.00%> (-4.86%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@Lukewh Lukewh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codeEmpress1 codeEmpress1 merged commit 9f201a4 into canonical:main Sep 28, 2023
@codeEmpress1 codeEmpress1 deleted the update-beta-app branch September 28, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants