Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charmhub incorrectly recognises a charm's substrate #1417

Open
mthaddon opened this issue Oct 24, 2022 · 7 comments
Open

charmhub incorrectly recognises a charm's substrate #1417

mthaddon opened this issue Oct 24, 2022 · 7 comments

Comments

@mthaddon
Copy link
Contributor

Currently https://charmhub.io/nginx-ingress-integrator is listed as "Ubuntu 20.04" in terms of platform. However, this is a k8s charm, as denoted by the following in metadata.yaml:

assumes:
  - k8s-api
@jkfran
Copy link
Contributor

jkfran commented Oct 26, 2022

I will repeat here what I said on Mattermost:

The homepage of Charmhub uses the find endpoint from PublisherGW. The find endpoint doesn't provide the content of the metadata.yaml. This endpoint returns a field result.deployable-on which we use to show these icons:
image

In this case, the value of this field is empty. When this value is empty, we decided to show VM because it was the case for most of the charms. @Roadmaster, could the API consider what Tom mentioned in the metadata.yaml to return "Kubernetes"?

@Roadmaster
Copy link

I would like to have some documentation on what the possible values for "assumes" are, before updating the rule that determines deployable-on. Can you or Tom point us to it?

Thanks!

@mthaddon
Copy link
Contributor Author

All I can find is https://juju.is/docs/sdk/assumes but that doesn't seem to cover all the values (it seems like it can be anything).

@juanmanuel-tirado
Copy link

At this point Juju only processes juju and k8s-api assumes AFAIK. See the code here

@Lukewh
Copy link
Contributor

Lukewh commented Nov 24, 2022

Is this being tracked somewhere else? Happy to leave this issue open until we hear more, but it sounds like there's nothing for the webteam to do for now.

@mthaddon
Copy link
Contributor Author

@Roadmaster is there an update on this? Should we be tracking the issue elsewhere?

@mthaddon
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants