[DPE-4345] Disable pgBackRest service initialisation #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
dragomirp
reviewed
Jul 12, 2024
snap/snapcraft.yaml
Outdated
| @@ -239,7 +240,7 @@ parts: | |||
| - locales-all | |||
| # Landscape deps | |||
| - postgresql-14-debversion=1.1.1-5 | |||
| - postgresql-plpython3-14=14.11-0ubuntu0.22.04.1 | |||
| - postgresql-plpython3-14 | |||
There was a problem hiding this comment.
We should move the pin here to 14.12-0ubuntu0.22.04.1
There was a problem hiding this comment.
Sure. Pinned on c0472ff.
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
|
We will need to bump the Postgresql version in the rock as well once we publish the snap. |
dragomirp
approved these changes
Jul 12, 2024
lucasgameiroborges
approved these changes
Jul 15, 2024
marceloneppel
deleted the
dpe-4345-disable-pgbackrest-service-initialisation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The pgBackRest TLS service is enabled in the Snap, which makes it start automatically on boot in the charm, creating some noise in the system logs, like the following (from canonical/postgresql-operator#468):
charmed-postgresql.pgbackrest-service[7546]: ERROR: [037]: server command requires option: tls-server-authSolution
Disable the service initialisation in the snap.
Also, update the snap version to 14.12 (because that's the PostgreSQL version we have in the repositories now) and fix the name of the
plpython3package to match the new PostgreSQL version.Services in the charm after this fix (
charmed-postgresql.prometheus-postgres-exporterneeds to be disabled in the charm code, but this will probably be done after we add some logic to handle its start after COS is related to the PG charm):ubuntu@juju-337094-0:~$ sudo snap services charmed-postgresql Service Startup Current Notes charmed-postgresql.patroni disabled active - charmed-postgresql.pgbackrest-exporter disabled inactive - charmed-postgresql.pgbackrest-service disabled inactive - charmed-postgresql.prometheus-postgres-exporter enabled inactive -