add support bionic #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use older python and ops to test bionic
|
@wolsen Although there are issue with signed off by but could you please review this one? |
|
Note the Signed-off-by DCO check are failing because the commits are not signed of with -s when doing git commit. A couple of comments in-line, but overall looking good. |
wolsen
requested changes
Jul 23, 2024
Signed-off-by: Seyeong Kim <[email protected]>
Thanks a lot! |
wolsen
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I'm testing current ops, there was some issues in ops library. and I asked ops team to take a look at that.
They helped me to support bionic with current code.
I create this pull request with their code.
Thanks a lot.