KU-1061 ROCKs for cert-manager #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
maci3jka
changed the title
maci3jka
changed the title
Co-authored-by: Berkay Tekin Öz <[email protected]>
berkayoz
force-pushed
the
story/KU-1061/rocks-and-test
branch
from
8c54a0e
to
652868d
Compare
bschimke95
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
LGTM, but for reference: I'm not a big fan of copying the test harness code into all rock repositories. Eventually, we need to move that into its own repo and just pull it. Please create a follow-up card for this @berkayoz.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code moved from #2