fix: Try to convert ESX VM UUID after hw upgrade #415
+30
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jirihnidek
commented
Jul 31, 2024
jirihnidek
commented
- Card ID: CCT-606
- It is only draft ATM, because I cannot test it
jirihnidek
force-pushed
the
jhnidek/CCT-606
branch
2 times, most recently
from
ea1ddc5 to
02aa2bc
Compare
|
/packit test |
|
/packit build |
jirihnidek
force-pushed
the
jhnidek/CCT-606
branch
from
02aa2bc to
ff160c1
Compare
jirihnidek
force-pushed
the
jhnidek/CCT-606
branch
from
84948b8 to
0e4b19e
Compare
cnsnyder
reviewed
Jan 23, 2025
virtwho/virt/esx/esx.py
Outdated
| version = int(vm['config.version'].split('-')[1]) | ||
| if (version >= 13): | ||
|
|
||
| # Try to some crazy heuristics |
There was a problem hiding this comment.
Non nacking comment: I think this sentence does not need the "to".
"Try to some crazy heuristics" -> "Try some crazy heuristics".
There was a problem hiding this comment.
Updated comment to be more descriptive.
* Card ID: CCT-606 * It is only draft ATM, because I cannot test it
* Card ID: CCT-606 * Added more debug prints * Changed the logic a little bit * TODO: squash this and previous commit, when it will work as expected
jirihnidek
force-pushed
the
jhnidek/CCT-606
branch
from
0e4b19e to
c9532e9
Compare
cnsnyder
reviewed
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.