Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: concurrency issue when elements were loading #331

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

katiestahl
Copy link
Contributor

@katiestahl katiestahl commented Sep 11, 2024

close #311

@katiestahl katiestahl added bug Something isn't working help wanted Extra attention is needed priority:high High priority labels Sep 11, 2024
@katiestahl katiestahl changed the title fix: issue where changing order of elements with tx segment elements … fix: concurrency issue when elements were loading Sep 12, 2024
@katiestahl katiestahl self-assigned this Sep 12, 2024
@katiestahl katiestahl marked this pull request as ready for review September 12, 2024 18:30
@korikuzma
Copy link
Member

@jarbesfeld can you test this out first?

@jarbesfeld
Copy link
Contributor

@korikuzma Do I need to install locally to test? If so, I may need some help getting it set up

@korikuzma
Copy link
Member

@jarbesfeld Yes. The readme should be up-to-date. Let me know if you have any issues.

Copy link

This PR is stale because it has been open 1 day(s) with no activity. Please review this PR.

Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't reproduce the issue anymore! Nice

@katiestahl katiestahl merged commit 9158eb3 into staging Sep 17, 2024
6 checks passed
@korikuzma korikuzma deleted the issue-311-concurrency branch October 3, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed priority:high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants