Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix: concurrency issues with async requests #328

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions client/src/services/apiService.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
// a service layer for api requests that enables reusability of abort controllers
class ApiService {
private controllers: Map<string, AbortController>;

constructor() {
this.controllers = new Map();
}

public async makeRequest<T>(
key: string,
url: string,
options?: RequestInit
): Promise<T> {
if (this.controllers.has(key)) {
this.controllers.get(key)?.abort();
}

const controller = new AbortController();
this.controllers.set(key, controller);

try {
const response = await fetch(url, {
...options,
signal: controller.signal,
});

const data: T = await response.json();
return data;
} finally {
this.controllers.delete(key);
}
}

public cancelRequest(key: string) {
if (this.controllers.has(key)) {
this.controllers.get(key)?.abort();
}
}
}

export const apiService = new ApiService();
Loading