Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: define in pyproject.toml #285

Merged
merged 9 commits into from
Jul 16, 2024
Merged

build!: define in pyproject.toml #285

merged 9 commits into from
Jul 16, 2024

Conversation

jsstevenson
Copy link
Member

@jsstevenson jsstevenson commented Jul 12, 2024

close #275

  • use src/ layout <-- could make deployment finicky, we should double check (I think it's fine from looking at how the procfile calls it, but we'll need to watch deployment next time)
  • define build configs in pyproject.toml using setuptools-scm rather than version.py
  • update some associated metadata

@jsstevenson jsstevenson added the priority:low Low priority label Jul 12, 2024
@jsstevenson
Copy link
Member Author

jsstevenson commented Jul 16, 2024

Need to update .pre-commit-config in a separate PR. Setup-based checks should start passing once we put out a proper release (can do so after this PR) and fix linting/formatting (separate PR).

@jsstevenson jsstevenson added priority:medium Medium priority and removed priority:low Low priority labels Jul 16, 2024
@korikuzma
Copy link
Member

use src/ layout <-- could make deployment finicky, we should double check (I think it's fine from looking at how the procfile calls it, but we'll need to watch deployment next time)

@jsstevenson I think you need to change Procfile to cd server/src. I had to do this for MetaKB and Variation Normalizer.

.github/ISSUE_TEMPLATE/bug-report.yaml Outdated Show resolved Hide resolved
server/src/curfu/__init__.py Outdated Show resolved Hide resolved
@jsstevenson
Copy link
Member Author

@jsstevenson I think you need to change Procfile to cd server/src. I had to do this for MetaKB and Variation Normalizer.

@korikuzma good intel! I guess I can see why that might happen

@jsstevenson jsstevenson requested a review from korikuzma July 16, 2024 12:54
.github/workflows/stale.yaml Outdated Show resolved Hide resolved
@jsstevenson jsstevenson merged commit cb83cb3 into staging Jul 16, 2024
1 of 5 checks passed
@jsstevenson jsstevenson deleted the pyproject-build branch July 16, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants