-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add transcript lookup for genes #273
Conversation
…nts/fusion-curation into issue-222-coord-lookup
…ration into issue-222-coord-lookup
…rs gene autocomplete
sorry for delay, this is on my to-do to review this morning |
lol |
This PR is stale because it has been open 3 day(s) with no activity. Please review this PR. |
cool-seq-tool updates are now completed, so this is back on my docket! |
This PR is stale because it has been open 3 day(s) with no activity. Please review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jarbesfeld and I are reviewing together. It looks great!
Some suggestions to address in future issues:
- Maybe consider having a smaller scrollable box for genes that have many transcripts
- @jarbesfeld suggested labeling which transcripts are MANE select/clinical plus in the dropdown
- Some larger transcripts get cut off
client/src/components/Utilities/GetCoordinates/GetCoordinates.tsx
Outdated
Show resolved
Hide resolved
client/src/components/Utilities/GetCoordinates/GetCoordinates.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Kori Kuzma <[email protected]>
Co-authored-by: Kori Kuzma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good. I think we could consider (?) reversing the order that transcript options appear in the dropdown, although it seems like the right one tends to be preselected, which is probably enough.
added this to the issue where we'll display MANE/clinical plus transcript catergories on the dropdown! |
in this PR:
fusor
versioncool-seq-tool
calls to correspond with new versiongene-normalizer
versionpydantic
to v2Transcript
field in genomic coordinate conversion tool with transcripts once a user selects a geneclose #224
close #222
close #272