[Proposal] fix(prober): return "not supported" if browser API take too long #1470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
navigator.requestMediaKeySystemAccess()
can hang infinitly on some devices. (Noticed on a windows device in an app under WebView v2).As a result,
mediaCapabilitiesProber.getCompatibleDRMConfigurations()
hangs infinitly and does not return the supported key systems.To handle such case, I propose to add a timeout when testing such browser APIs, and to consider that the device has not the capabilities for this media configuration if no response is given in a reasonable time (I have set it to 30 seconds).
I added this behavior for the following browsers API: