Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark job worker-based user task managed by Camunda as deprecated #125

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Dec 11, 2024

Related to camunda/camunda-modeler#4690

Needs to integrate https://github.com/camunda/bpmnlint-plugin-camunda-compat/pull/183/commits first because the rule currently doesn't exist

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Dec 11, 2024
@Skaiir Skaiir force-pushed the 4690-zeebe-user-task-deprecation branch from ba011a4 to 97ff2af Compare December 11, 2024 15:28
@Skaiir Skaiir marked this pull request as ready for review December 11, 2024 15:32
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 11, 2024
@barmac barmac force-pushed the 4690-zeebe-user-task-deprecation branch from 487fbc6 to 9ed5ee1 Compare December 12, 2024 10:35
@barmac barmac changed the title fix: adjusted the zeebe:userTask required message Mark job worker-based user task managed by Camunda as deprecated Dec 12, 2024
Copy link
Contributor

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've adjusted the error message to be specific. I think the PR is good to merge. Thanks for the contribution.

image

@barmac barmac merged commit bcf840b into main Dec 12, 2024
3 checks passed
@barmac barmac deleted the 4690-zeebe-user-task-deprecation branch December 12, 2024 10:38
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 12, 2024
@barmac
Copy link
Contributor

barmac commented Dec 12, 2024

Second thought: We might not want to link to next:

https://docs.camunda.io/docs/next/apis-tools/migration-manuals/migrate-to-zeebe-user-tasks

@barmac
Copy link
Contributor

barmac commented Dec 12, 2024

We use it for the rules though. Potential follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants