Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(email-connector): add document handling to the email connector #3645

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(email-connector): add document handling to the email connector #3645

wants to merge 7 commits into from

Conversation

mathias-vandaele
Copy link
Contributor

Description

Add document handling feature to the email connector

Related issues

closes #3643

Checklist

  • PR has a milestone or the no milestone label.

@mathias-vandaele mathias-vandaele requested a review from a team as a code owner November 13, 2024 15:41
@mathias-vandaele mathias-vandaele linked an issue Nov 13, 2024 that may be closed by this pull request
[Email connector] Add document handling feature for email connector #3643
Open
@mathias-vandaele mathias-vandaele self-assigned this Nov 13, 2024
@mathias-vandaele mathias-vandaele added this to the 8.7.0-alpha2 milestone Nov 13, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 13, 2024
View reviewed changes
...main/java/io/camunda/connector/email/client/jakarta/outbound/JakartaEmailActionExecutor.java
@@ -37,7 +42,9 @@
return new JakartaEmailActionExecutor(sessionFactory, objectMapper);
}

public Object execute(EmailRequest emailRequest) {
public Object execute(OutboundConnectorContext context) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
EmailActionExecutor.execute
Loading
; it is advisable to add an Override annotation.
...ctors/email/src/test/java/io/camunda/connector/email/client/jakarta/JakartaExecutorTest.java Fixed Show fixed Hide fixed
...ectors/email/src/test/java/io/camunda/connector/email/client/jakarta/PollingManagerTest.java Fixed Show fixed Hide fixed
@mathias-vandaele mathias-vandaele marked this pull request as draft November 13, 2024 16:26
@mathias-vandaele mathias-vandaele marked this pull request as ready for review November 13, 2024 16:49
@mathias-vandaele mathias-vandaele force-pushed the 3643-email-connector-add-document-handling-feature-for-email-connector branch from f5a96af to 62c3256 Compare November 14, 2024 16:29
@mathias-vandaele mathias-vandaele marked this pull request as draft November 18, 2024 14:52
@mathias-vandaele mathias-vandaele force-pushed the 3643-email-connector-add-document-handling-feature-for-email-connector branch from 62c3256 to 05d9cb2 Compare November 22, 2024 09:27
@mathias-vandaele mathias-vandaele marked this pull request as ready for review November 22, 2024 09:27
johnBgood
johnBgood reviewed Nov 22, 2024
View reviewed changes
...rs/email/src/main/java/io/camunda/connector/email/client/jakarta/inbound/PollingManager.java Outdated
email.receivedAt()));
}

private List<Document> createDocumentList(Email email, InboundConnectorContext connectorContext) {
if (connectorContext.canActivate(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shold be !canActivate , right?

johnBgood
johnBgood reviewed Nov 22, 2024
View reviewed changes
...email/src/main/java/io/camunda/connector/email/outbound/protocols/actions/SmtpSendEmail.java Outdated
optional = true,
description = "Email's attachment",
binding = @TemplateProperty.PropertyBinding(name = "data.smtpAction.attachment"))
Document attachment)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we send only 1 attachment then?

johnBgood
johnBgood reviewed Nov 22, 2024
View reviewed changes
...main/java/io/camunda/connector/email/client/jakarta/outbound/JakartaEmailActionExecutor.java
@@ -337,4 +364,17 @@ private Optional<InternetAddress[]> createParsedInternetAddresses(Object object)
"Unexpected value: " + object + ". List or String was expected");
});
}

private List<Document> createDocumentList(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a code in PollingManager that looks like this one, do we want to re this function in the PollingManager?

@mathias-vandaele mathias-vandaele added component:qa Task containing all details related to QA deploy-preview qa:required Will trigger the QA workflow labels Nov 25, 2024
@johnBgood
Copy link
Collaborator

QA information

Test Environment

  • Environment:
    • SaaS only
    • SM only
    • Both
  • Connectors version: <TO_BE_REPLACED>

Test Scope

Please describe the test scope, happy path, edge cases that come to your mind, and whatever you think might relevant to test

Test Data

Please provide the test data, if needed (files, URLs, code snippets, FEEL expressions)

@github-actions github-actions bot temporarily deployed to connectors-3643-email-conn-c8sm November 25, 2024 08:32 Destroyed
@mathias-vandaele mathias-vandaele force-pushed the 3643-email-connector-add-document-handling-feature-for-email-connector branch from 493a3ee to a3990dc Compare November 28, 2024 11:10
@github-actions github-actions bot temporarily deployed to connectors-3643-email-conn-c8sm November 28, 2024 11:10 Destroyed
@mathias-vandaele mathias-vandaele force-pushed the 3643-email-connector-add-document-handling-feature-for-email-connector branch from a3990dc to 17fe1e8 Compare November 28, 2024 11:12
@github-actions github-actions bot temporarily deployed to connectors-3643-email-conn-c8sm November 28, 2024 11:12 Destroyed
@github-actions github-actions bot had a problem deploying to connectors-3643-email-conn-c8sm November 28, 2024 15:04 Failure
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployment Results 🚀

Please find below the results of the latest deployments.

connectors-3643-email-conn-c8sm

🔧 Troubleshooting 🔧

The 🔗 ArgoCD link can be used to check the state and configuration of all the services deployed as part of the preview environments and get logs.

In case of error, please check 📋 Deployment Jobs and 🔗 ArgoCD to debug, and check our (yet to come) troubleshooting page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnBgood johnBgood johnBgood approved these changes

Assignees

@mathias-vandaele mathias-vandaele

Labels
component:qa Task containing all details related to QA deploy-preview qa:required Will trigger the QA workflow
Projects
None yet
Milestone
8.7.0-alpha2
Development

Successfully merging this pull request may close these issues.

[Email connector] Add document handling feature for email connector
2 participants
@mathias-vandaele @johnBgood