Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(element-templates): Update element template descriptions and add keywords #3466

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

chore(element-templates): Update element template descriptions and add keywords #3466

wants to merge 14 commits into from

Conversation

philippfromme
Copy link

@philippfromme philippfromme commented Oct 8, 2024 •
edited by johnBgood
Loading

Description

  • adds support for a metadata property with keywords (already supported by element templates)
  • in order for refactorings feature to be able to suggest better refactorings
    • updates descriptions of existing element templates
    • adds keywords to existing element templates

Related issues

Closes #3089

Checklist

  • PR has a milestone or the no milestone label.

@philippfromme philippfromme changed the title Metadata keywords Update element template descriptions and add keywords Oct 8, 2024
@philippfromme philippfromme mentioned this pull request Oct 8, 2024
Open
@philippfromme
Copy link
Author

@johnBgood Can you have a look whether the update description and add keywords commits look okay? If yes, I'd continue. Also, I'm not sure why the tests are failing. I've used @ElementTemplate.Metadata in the same way as in the example.

@johnBgood johnBgood changed the title Update element template descriptions and add keywords chore(element-templates): Update element template descriptions and add keywords Oct 14, 2024
@johnBgood
Copy link
Collaborator

You needed to run mvn spotless:apply, it was just a listing issue 👍
I did that, let's see if the tests are passing now.

I'll check the commits later today, or tomorrow.

@johnBgood
Copy link
Collaborator

@philippfromme Commits look good! :)

@philippfromme philippfromme force-pushed the metadata-keywords branch 2 times, most recently from 0ca971c to 7749be0 Compare November 4, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update template descriptions and add keywords to improve refactorings suggestions
2 participants
@philippfromme @johnBgood