Element Template generation: set notEmpty: false explicitly #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbuettner
previously approved these changes
May 28, 2024
|
@sbuettner could this be regarded as a bugfix and be backported to 8.5? |
|
@jonathanlukas Yes, sure |
sbuettner
force-pushed
the
allow-not-empty-false
branch
from
21ffef8 to
f878bf5
Compare
sbuettner
approved these changes
May 29, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/8.5
git worktree add -d .worktree/backport-2675-to-release/8.5 origin/release/8.5
cd .worktree/backport-2675-to-release/8.5
git switch --create backport-2675-to-release/8.5
git cherry-pick -x 69eb232fa1bb51d005ce9462145f9e5c03a73bad |
jonathanlukas
added a commit
that referenced
this pull request
Jun 3, 2024
* set notEmpty: false explicitly * added tests (cherry picked from commit 69eb232) # Conflicts: # element-template-generator/core/src/main/java/io/camunda/connector/generator/java/processor/FieldProcessor.java # element-template-generator/core/src/main/java/io/camunda/connector/generator/java/processor/TemplatePropertyFieldProcessor.java # element-template-generator/core/src/test/java/io/camunda/connector/generator/java/example/outbound/MyConnectorInput.java
jonathanlukas
added a commit
that referenced
this pull request
Jun 3, 2024
…2690) * Element Template generation: set notEmpty: false explicitly (#2675) * set notEmpty: false explicitly * added tests (cherry picked from commit 69eb232) # Conflicts: # element-template-generator/core/src/main/java/io/camunda/connector/generator/java/processor/FieldProcessor.java # element-template-generator/core/src/main/java/io/camunda/connector/generator/java/processor/TemplatePropertyFieldProcessor.java # element-template-generator/core/src/test/java/io/camunda/connector/generator/java/example/outbound/MyConnectorInput.java * revert some changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On template generation, there seems to be no way to have
constraints.notEmptybeing set to true.However, this is currently required to achieve a field that has a regex for validation but may remain empty.
This PR enables this behaviour for template property fields and jakarta validation annotations on processing.
Related issues
camunda/camunda-modeler#4314 (comment)
closes #