Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client-secret should only be present when string literal provided for oidc #2733

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

hamza-m-masood
Copy link
Contributor

Which problem does the PR fix?

closes: #2727

What's in this PR?

I am fixing the client-secret section in identity configmap. it should render when a string literal is provided and should not render when a k8s secret is provided.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@github-actions github-actions bot added version/8.5 Camunda applications/cycle version component/identity labels Jan 6, 2025
@jessesimpson36
Copy link
Contributor

Seems like a reasonable change to me. do you intend to forward-port / backport it to the other versions, or just 8.5?

@jessesimpson36 jessesimpson36 self-requested a review January 7, 2025 00:54
@hamza-m-masood
Copy link
Contributor Author

hamza-m-masood commented Jan 7, 2025

Thanks @jessesimpson36 I wil make this change to all charts from 8.5 and above.
This change is not necessary for 8.4 since identity exclusively uses env vars

@github-actions github-actions bot added version/8.6 Camunda applications/cycle version version/alpha Camunda applications/cycle version (this is a pointer to alpha) labels Jan 7, 2025
@hamza-m-masood hamza-m-masood marked this pull request as ready for review January 7, 2025 19:33
@hamza-m-masood
Copy link
Contributor Author

hamza-m-masood commented Jan 7, 2025

I am assuming the integration tests and unit tests for alpha are still broken. I will merge with that assumption

@hamza-m-masood hamza-m-masood merged commit 6cd9313 into main Jan 7, 2025
29 of 32 checks passed
@hamza-m-masood hamza-m-masood deleted the oidc-fix branch January 7, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/identity version/alpha Camunda applications/cycle version (this is a pointer to alpha) version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] identity client-id for OIDC is not set when an existingSecret is used
2 participants