Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency electron to v34 #4789

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 14, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
electron ^33.0.0 -> ^34.0.0 age adoption passing confidence

Release Notes

electron/electron (electron)

v34.0.0: electron v34.0.0

Compare Source

Release Notes for v34.0.0

Other Changes

  • Updated Chromium to 132.0.6834.83. #​45164

Documentation

v33.3.1: electron v33.3.1

Compare Source

Release Notes for v33.3.1

Fixes

  • Fixed chrome.i18n extension API being unavailable in service workers. #​45037 (Also in 31, 32, 34)
  • Fixed build failure when the PDF viewer is disabled. #​44965 (Also in 34)
  • Fixed custom spell checker getting stuck in infinite loop using 100% CPU. #​45021 (Also in 31, 32, 34)
  • Fixed issue with missing index arg for webContents.canGoToOffset. #​45006 (Also in 32, 34)

Other Changes

  • Updated Chromium to 130.0.6723.170. #​45061

v33.3.0: electron v33.3.0

Compare Source

Release Notes for v33.3.0

Features

  • Added APIs to manage shared dictionaries for compression efficiency using Brotli or ZStandard. The new APIs are session.getSharedDictionaryUsageInfo(), session.getSharedDictionaryInfo(options), session.clearSharedDictionaryCache(), and session.clearSharedDictionaryCacheForIsolationKey(options). #​44951 (Also in 34)
  • Added WebFrameMain.collectJavaScriptCallStack() for accessing the JavaScript call stack of unresponsive renderers. #​44937 (Also in 34)

Fixes

  • Fixed an possible crash when using draggable regions and BaseWindows to get the context-menu event. #​44953 (Also in 32, 34)

Other Changes

  • Updated Chromium to 130.0.6723.152. #​44948

Documentation

v33.2.1: electron v33.2.1

Compare Source

Release Notes for v33.2.1

Fixes

  • Fixed a crash that could occur when calling shell.readShortcutLink on Windows. #​44803 (Also in 34)
  • Fixed an issue where WebContentsViews were being improperly removed. #​44671 (Also in 31, 32, 34)
  • Fixed an issue where resize wasn't being emitted for single-pixel resizes on Windows. #​44723 (Also in 32, 34)
  • Fixed an issue where a utilityProcess pid would not be undefined after exit. #​44694 (Also in 32, 34)
  • Fixed an issue where buttons shown under the Window Controls Overlay API were missing tooltips. #​44757 (Also in 32, 34)
  • Fixed an issue where the webContents context-menu event was not emitted when using -webkit-app-region: drag. #​44800 (Also in 32, 34)
  • Fixed an issue where the windows control overlay was unexpectedly visible in fullscreen on Linux. #​44640 (Also in 31, 32, 34)
  • Fixed crash in net api when utility process exits. #​44729 (Also in 32, 34)
  • Fixed segfault when moving WebContentsView between BrowserWindows. #​44613 (Also in 31, 32, 34)
  • Fixed theme does not work in DevTools. #​44635 (Also in 32, 34)
  • Fixed update file extension bug. #​44771 (Also in 34)
  • Return 0 exit code for normal termination of the utility process. #​44732 (Also in 32, 34)

Other Changes

  • Fixed an issue where a deprecation warning was being incorrectly emitted for frameless windows on macOS. #​44767 (Also in 34)
  • Fixed drag-and-drop session being canceled on wayland with empty dragData. #​44753 (Also in 32)
  • Security: backported fix for CVE-2024-11110. #​44647
  • Updated Chromium to 130.0.6723.137. #​44781
  • Updated Node.js to v20.18.1. #​44780

v33.2.0: electron v33.2.0

Compare Source

Release Notes for v33.2.0

Features

  • Added GPU accelerated shared texture offscreen rendering. #​44511

Other Changes

  • Updated Chromium to 130.0.6723.118. #​44591

v33.1.0: electron v33.1.0

Compare Source

Release Notes for v33.1.0

Features

  • Added WebFrameMain.detached for frames in an unloading state.
    • Added WebFrameMain.isDestroyed() to determine if a frame has been destroyed.
    • Fixed webFrameMain.fromId(processId, frameId) returning a WebFrameMain instance which doesn't match the given parameters when the frame is unloading. #​44209

Fixes

  • Fixed an issue where EventSource was undefined in both renderer and worker processes when Node.js integration was enabled. #​44496 (Also in 32, 34)
  • Fixed crash when network process terminates while a net log is running. #​44420 (Also in 31, 32, 34)
  • Fixed crash when rendering super menu accelerator on linux. #​44520 (Also in 34)
  • Fixed external window focus when using shell.openExternal. #​44468 (Also in 34)
  • Fixed regression with dynamic dependency on libgdk_pixbuf. #​44436 (Also in 32, 34)

Other Changes

  • Performance improvements when processing microtasks. #​44473 (Also in 32, 34)
  • Updated Chromium to 130.0.6723.91. #​44477

v33.0.2: electron v33.0.2

Compare Source

Release Notes for v33.0.2

Fixes

  • Fixed trace-startup not working on macOS. #​44276 (Also in 32, 34)
  • Fixed an issue where closing a window after printing on Linux triggered a crash. #​44285 (Also in 31, 32, 34)
  • Fixed an issue where the exit event could be emitted twice from the utilityProcess. #​44266 (Also in 31, 32, 34)
  • Fixed calling setAlwaysOnTop on a hidden window which is then shown with showInactive on Linux under X11. #​44324 (Also in 31, 32, 34)
  • Fixed race condition in which WebContents appears as white screen on VDI machines without hardware acceleration capabilities. #​44352 (Also in 32, 34)

v33.0.1: electron v33.0.1

Compare Source

Release Notes for v33.0.1

Other Changes

  • Updated Chromium to 130.0.6723.59. #​44271

Configuration

📅 Schedule: Branch creation - "after 10pm,before 5:00am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Updates a dependency label Jan 14, 2025
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 14, 2025
@barmac
Copy link
Collaborator

barmac commented Jan 16, 2025

The breaking change of electron@34 is about the menu visibility in full screen on Windows. Can you check that @philippfromme ?

@philippfromme
Copy link
Contributor

I will have a look.

@philippfromme
Copy link
Contributor

Electron <34

Menu bar visible.

image

Electron 34

Menu bar not visible.

image

Since this is in line with how Linux behaves and there's nothing we can do to change it I'd say let's merge. @barmac

@barmac barmac merged commit d784c50 into develop Jan 22, 2025
12 of 15 checks passed
@barmac barmac deleted the renovate/electron-34.x branch January 22, 2025 15:14
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 22, 2025
@github-actions github-actions bot added this to the M85 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants