Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process applications #4762

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Process applications #4762

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68316bc
chore: remove unused `endpoints`
philippfromme Nov 11, 2024
a9e53f8
chore: remove legacy
philippfromme Nov 18, 2024
10fd6a3
feat: process applications
philippfromme Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/lib/workspace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ class Workspace {

workspace.files = files;

workspace.endpoints = workspace.endpoints || [];

done(null, workspace);
});

Expand Down
15 changes: 5 additions & 10 deletions client/src/app/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,7 @@ const INITIAL_STATE = {
lintingState: {},
logEntries: [],
notifications: [],
currentModal: null,
endpoints: []
currentModal: null
};


Expand Down Expand Up @@ -1102,8 +1101,7 @@ export class App extends PureComponent {
recentTabs,
tabLoadingState,
tabState,
layout,
endpoints
layout
} = this.state;

const {
Expand Down Expand Up @@ -1136,8 +1134,7 @@ export class App extends PureComponent {
if (
activeTab !== prevState.activeTab ||
tabs !== prevState.tabs ||
layout !== prevState.layout ||
endpoints !== prevState.endpoints
Copy link
Member

@nikku nikku Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be used (again) once we support "endpoints" for deployment.

Why would we remove it here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Of course fine, if we consider to store the endpoints in a different place, once supported).

layout !== prevState.layout
) {
this.workspaceChanged();
}
Expand Down Expand Up @@ -1191,15 +1188,13 @@ export class App extends PureComponent {
const {
layout,
tabs,
activeTab,
endpoints
activeTab
} = this.state;

return onWorkspaceChanged({
tabs,
activeTab,
layout,
endpoints
layout
});
};

Expand Down
8 changes: 2 additions & 6 deletions client/src/app/AppParent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ const log = debug('AppParent');
const DEFAULT_CONFIG = {
activeFile: -1,
files: [],
layout: {},
endpoints: []
layout: {}
};


Expand Down Expand Up @@ -130,13 +129,10 @@ export default class AppParent extends PureComponent {

const layout = config.layout;

const endpoints = config.endpoints;

const workspaceConfig = {
files,
activeFile,
layout,
endpoints
layout
};

try {
Expand Down