Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formal parameters sync without reloading #4703

Closed
wants to merge 2 commits into from

Conversation

abdul99ahad
Copy link
Contributor

@abdul99ahad abdul99ahad commented Nov 19, 2024

Closes #4544

Proposed Changes

Previously: Formal parameters suggestions were not available in the literal expression until you reload the view
Changes: Formal parameters suggestions are available without reloading

Nov-19-2024 14-27-48

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 19, 2024
@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

This Pull Request targets develop branch, but contains fix commits.

Consider targeting main instead.

@abdul99ahad abdul99ahad requested a review from barmac November 19, 2024 11:56
@abdul99ahad abdul99ahad force-pushed the formal-param-sync branch 2 times, most recently from bc3b7a3 to 61a59bc Compare November 19, 2024 12:00
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Let's fix the changelog.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@nikku
Copy link
Member

nikku commented Nov 20, 2024

Closing in favor of #4620.

@nikku nikku closed this Nov 20, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 20, 2024
@nikku nikku added the dependencies Updates a dependency label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formal parameters suggestions are not reloaded until view is reopened
5 participants