Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update slackapi/slack-github-action action to v2 #4699

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 16, 2024

This PR contains the following updates:

Package Type Update Change
slackapi/slack-github-action action major v1 -> v2
slackapi/slack-github-action action major v1.15.0 -> v2.0.0

Release Notes

slackapi/slack-github-action (slackapi/slack-github-action)

v2

Compare Source


Configuration

📅 Schedule: Branch creation - "after 10pm,before 5:00am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Updates a dependency label Nov 16, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 16, 2024
Copy link
Contributor Author

renovate bot commented Nov 18, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@barmac barmac requested a review from nikku November 18, 2024 10:28
@@ -42,10 +42,10 @@ jobs:
secret/data/products/desktop-modeler/ci/slack_integration SLACK_CHANNEL_ID;
secret/data/products/desktop-modeler/ci/slack_integration SLACK_BOT_TOKEN;
- name: Notify on Slack if merge fails
uses: slackapi/slack-github-action@v1
if: failure()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant as the job contains the failure condition already.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this 👏

@barmac barmac merged commit 7ca14c0 into develop Nov 18, 2024
10 of 12 checks passed
@barmac barmac deleted the renovate/slackapi-slack-github-action-2.x branch November 18, 2024 10:41
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 18, 2024
@github-actions github-actions bot added this to the M83 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants