Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: larger names shrunk in variable tab #4696

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

abdul99ahad
Copy link
Contributor

@abdul99ahad abdul99ahad commented Nov 14, 2024

Proposed Changes

Incorporates upstream changes from bpmn-io/variable-outline#5

Closes #4505

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 14, 2024
@abdul99ahad abdul99ahad requested review from philippfromme, nikku and barmac and removed request for philippfromme November 14, 2024 16:24
Copy link

This Pull Request targets develop branch, but contains fix commits.

Consider targeting main instead.

@abdul99ahad abdul99ahad force-pushed the variable-outline/shrink-names branch from 31c1d1e to 5d24992 Compare November 18, 2024 08:52
@abdul99ahad abdul99ahad changed the base branch from develop to main November 18, 2024 08:52
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@nikku
Copy link
Member

nikku commented Nov 19, 2024

@abdul99ahad as a good practice, attach a screenshot of the fix in place (to establish context).

@nikku nikku force-pushed the variable-outline/shrink-names branch from d2aa1c0 to 8f1438d Compare November 19, 2024 07:48
@nikku nikku changed the base branch from main to develop November 19, 2024 07:48
@nikku
Copy link
Member

nikku commented Nov 19, 2024

Cleaned up commit history + targeted develop. We'll otherwise need to handle the merge conflicts elsewhere (and we're close to the next release anyway).

fix: prevent long element names from shrinking icon

  Closes #4505
@nikku nikku force-pushed the variable-outline/shrink-names branch from 8f1438d to ebdc2b7 Compare November 19, 2024 07:51
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this is fixed:

image

@abdul99ahad
Copy link
Contributor Author

Cleaned up commit history + targeted develop. We'll otherwise need to handle the merge conflicts elsewhere (and we're close to the next release anyway).

Initially, I was targeting the branch develop but github-action forced me to target main 🤡

@abdul99ahad abdul99ahad merged commit 00f1a37 into develop Nov 19, 2024
10 of 12 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 19, 2024
@abdul99ahad abdul99ahad deleted the variable-outline/shrink-names branch November 19, 2024 09:45
@github-actions github-actions bot added this to the M83 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Larger element names reduces the icon size in variables tab
2 participants