Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create_release action (issue link, slack message) #4693

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fix create_release action (issue link, slack message) #4693

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abc8f26
ci: pass issue to outputs
barmac Nov 14, 2024
6744dbc
ci: compose message with GHA expression
barmac Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/RELEASE_ISSUE.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
github.event.action == 'closed'
outputs:
assignee: ${{ steps.create_release_issue.outputs.assignee }}
issue: ${{ steps.create_release_issue.outputs.issue }}
steps:
- id: create_release_issue
name: Create new Release Issue
Expand Down Expand Up @@ -102,7 +103,7 @@ jobs:
uses: slackapi/slack-github-action@v1
with:
channel-id: ${{ steps.secrets.outputs.SLACK_CHANNEL_ID }}
slack-message: "Assigned <https://github.com/$RELEASE_MANAGER|@$RELEASE_MANAGER> as the release manager. Go to <$ISSUE_LINK|the release issue> to update if necessary."
slack-message: "Assigned <https://github.com/${{ env.RELEASE_MANAGER }}|@${{ env.RELEASE_MANAGER }}> as the release manager. Go to <${{ env.ISSUE_LINK }}|the release issue> to update if necessary."
env:
SLACK_BOT_TOKEN: ${{ steps.secrets.outputs.SLACK_BOT_TOKEN }}
# Release manager is either the assignee from the newly created issue or the new assigned from the `assigned` trigger
Expand Down